Shape your commits with Gerrit

Manuel Vacelet / @vaceletm & Martin Goyot / @Erwyn

Creative Commons License
This work is licensed under a Creative Commons Attribution-ShareAlike 3.0 Unported License.

Bio / context

  • Manuel: Enalean CTO & Tuleap developer
  • Martin: Tuleap developer
  • Tuleap is a forge

Why to review code?

Where it comes from?

  • Well known practice in FLOSS world
  • Various strategy: patches (LKML), "pull requests", ...

Gerrit

http://code.google.com/p/gerrit/

  • Comes from Android project
  • Git only
  • Users: Eclipse, Openstack, Sony, Motorola, Google, SAP, ...

Gerrit workflow

Reviews dashboard

One review

Patch

Diff, comments

Push for review

git push ssh://vaceletm@gerrit.tuleap.net:29418 HEAD:refs/for/master
  • One commit == One review
  • Shape your commits (history rewriting!)

Commits: Size matters

  • Beware The Big One
  • Difficult to grasp it
  • Tiny not better whatsoever

Shape your commits!

The tricky part

Tuleap help

  • Ease of startup
    • project initialization
    • default permissions

  • Large scale deployments
    • permissions template
    • group management

Conclusion

  • Pro tip: reduce the wait list
  • Pro tip: damn fast Continuous Integration
  • @EnaleanTeam: highest dev ROI this year

Questions?

Credits